Skip to content

Add prf extension#413

Merged
emlun merged 12 commits intomainfrom
prf-extension
Apr 4, 2025
Merged

Add prf extension#413
emlun merged 12 commits intomainfrom
prf-extension

Conversation

@fdennis
Copy link
Copy Markdown
Contributor

@fdennis fdennis commented Apr 3, 2025

No description provided.

fdennis and others added 8 commits March 5, 2025 12:00
This fixes test errors like the following:

```
Exception com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot find a (Map) Key deserializer for type [simple type, class com.yubico.webauthn.data.PublicKeyCredentialDescriptor] [in thread "Test worker"]
```

which also by extension means even if we fix the deserializer resolution,
`JsonIoSpec` will fail with `PublicKeyCredentialDescriptor` as keys because
input/output JSON will not be identical after deserializing from just the
credential ID. Therefore let's change the map key type to `ByteArray`. We can
keep the `PublicKeyCredentialDescriptor` key type in setters, but transform to
`ByteArray` keys during construction of the `PrfAuthenticationInput` value.
The factory functions on PrfRegistrationInput and PrfAuthenticationInput should
be enough.
@fdennis fdennis requested a review from emlun April 3, 2025 11:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Test Results

2 267 tests   2 259 ✅  1m 6s ⏱️
   46 suites      8 💤
   46 files        0 ❌

Results for commit 538e565.

♻️ This comment has been updated with latest results.

@emlun emlun merged commit d434110 into main Apr 4, 2025
20 checks passed
@emlun emlun deleted the prf-extension branch April 4, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants